Application class config #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config option applicationClass allows you to specify which type of application you want in your test suite.
|
@samdark could you confirm that the reasoning makes sense? I'm not familiar with the yii app templates or The code itself here LGTM |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was testing an application, I realized that it is impossible to change the application class without creating extra config files. By checking the code, I saw that it should be possible to determine the application class by setting a root level
classkey in the application config file (e.g.common/config/test.php). The issue with that isyii_testis loading this config file as well and get ayii\base\UnknownPropertyExceptionwith the message 'Setting unknown property: yii\console\Application::class'.So either you modify
yii_testto unset the class key before creating the console application or create another config file just for codeception and define the class there.Thus I felt, it would be more sensible to have this configuration value in the codeception module itself.